Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3600)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 882443003: Disable -Wl,--as-needed in sanitizer mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 255a2cd0a9750e5c3b514cb59f6383d577fb2857..d61e8ea2175bc884c8f56f5d074c5d953db4984b 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -948,9 +948,14 @@ if (is_win) {
# Specifically tell the linker to perform optimizations.
# See http://lwn.net/Articles/192624/ .
"-Wl,-O1",
- "-Wl,--as-needed",
"-Wl,--gc-sections",
]
+
+ if (!using_sanitizer) {
+ # As needed has a history of having problems with asan. See 234010 and
Nico 2015/01/27 04:39:38 fwiw,i like the comment in build/common.gypi more
+ # 452105 for examples.
+ common_optimize_on_ldflags += [ "-Wl,--as-needed" ]
+ }
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698