Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 882443003: Disable -Wl,--as-needed in sanitizer mode. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 10 months ago
Reviewers:
Nico
CC:
chromium-reviews, jamesr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable -Wl,--as-needed in sanitizer mode. We've had problems with this linker flag in --as-needed a few times now; just disable it if we're doing a sanitizer build. BUG=452105 Committed: https://crrev.com/009e710e139692929e181400bcc97c71235b892e Cr-Commit-Position: refs/heads/master@{#313321}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change comment to the gypi one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
Nico: This flag has caused problems with clock_gettime() in the past, on top of the ...
5 years, 11 months ago (2015-01-27 00:49:35 UTC) #2
Nico
lgtm, given that this matches what the gyp build does https://codereview.chromium.org/882443003/diff/1/build/config/compiler/BUILD.gn File build/config/compiler/BUILD.gn (right): https://codereview.chromium.org/882443003/diff/1/build/config/compiler/BUILD.gn#newcode955 ...
5 years, 11 months ago (2015-01-27 04:39:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882443003/20001
5 years, 10 months ago (2015-01-27 18:18:51 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-27 19:09:30 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 19:10:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/009e710e139692929e181400bcc97c71235b892e
Cr-Commit-Position: refs/heads/master@{#313321}

Powered by Google App Engine
This is Rietveld 408576698