Issue 88243004: Enhance SkDropShadowImageFilter to support separate X & Y sigmas, and crop rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88243004: Enhance SkDropShadowImageFilter to support separate X & Y sigmas, and crop rect. (Closed)

Created:
7 years ago by Stephen White

Modified:
7 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Enhance SkDropShadowImageFilter to support separate X & Y sigmas, and crop rect. This required a new flavour of the constructor. This is driven by the feDropShadow filter effect in SVG, which unlike the shorthand version accepts separate X & Y sigmas. Covered by new GM dropshadowimagefilter. R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12401

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -39 lines)			Patch
A +	gm/dropshadowimagefilter.cpp	View	5 chunks	+21 lines, -31 lines	0 comments	Download
M	gyp/gmslides.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/effects/SkDropShadowImageFilter.h	View	2 chunks	+2 lines, -1 line	1 comment	Download
M	src/effects/SkDropShadowImageFilter.cpp	View	4 chunks	+30 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

https://codereview.chromium.org/88243004/diff/1/include/effects/SkDropShadowImageFilter.h File include/effects/SkDropShadowImageFilter.h (right): https://codereview.chromium.org/88243004/diff/1/include/effects/SkDropShadowImageFilter.h#newcode15 include/effects/SkDropShadowImageFilter.h:15: SkDropShadowImageFilter(SkScalar dx, SkScalar dy, SkScalar sigmaX, SkScalar sigmaY, SkColor, ...

7 years ago (2013-11-26 20:58:39 UTC) #2

Stephen White

7 years ago (2013-11-26 21:52:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r12401 (presubmit successful).

Expand Messages | Collapse Messages