Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 882423002: Listen OnDisplayMetricsChanged on lock screen (Closed)

Created:
5 years, 10 months ago by Dmitry Polukhin
Modified:
5 years, 10 months ago
Reviewers:
oshima
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Listen OnDisplayMetricsChanged on lock screen BUG=453318 TEST=manual Committed: https://crrev.com/6469449b22b7c5b919ec353ecaa73e0e7766df07 Cr-Commit-Position: refs/heads/master@{#313909}

Patch Set 1 #

Total comments: 4

Patch Set 2 : comments fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -16 lines) Patch
M chrome/browser/chromeos/login/lock/webui_screen_locker.h View 1 4 chunks +18 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 9 chunks +33 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Dmitry Polukhin
PTAL
5 years, 10 months ago (2015-01-29 15:15:21 UTC) #2
oshima
lgtm with nits https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right): https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h#newcode117 chrome/browser/chromeos/login/lock/webui_screen_locker.h:117: // Overridden from gfx::DisplayObserver: nit: can ...
5 years, 10 months ago (2015-01-29 15:29:06 UTC) #3
Dmitry Polukhin
https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right): https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h#newcode117 chrome/browser/chromeos/login/lock/webui_screen_locker.h:117: // Overridden from gfx::DisplayObserver: On 2015/01/29 15:29:06, oshima wrote: ...
5 years, 10 months ago (2015-01-29 15:39:17 UTC) #4
oshima
https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right): https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h#newcode117 chrome/browser/chromeos/login/lock/webui_screen_locker.h:117: // Overridden from gfx::DisplayObserver: On 2015/01/29 15:39:17, Dmitry Polukhin ...
5 years, 10 months ago (2015-01-29 16:16:09 UTC) #5
Dmitry Polukhin
https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h File chrome/browser/chromeos/login/lock/webui_screen_locker.h (right): https://codereview.chromium.org/882423002/diff/1/chrome/browser/chromeos/login/lock/webui_screen_locker.h#newcode117 chrome/browser/chromeos/login/lock/webui_screen_locker.h:117: // Overridden from gfx::DisplayObserver: On 2015/01/29 16:16:09, oshima wrote: ...
5 years, 10 months ago (2015-01-30 13:08:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882423002/20001
5 years, 10 months ago (2015-01-30 13:08:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 13:59:32 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 14:02:00 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6469449b22b7c5b919ec353ecaa73e0e7766df07
Cr-Commit-Position: refs/heads/master@{#313909}

Powered by Google App Engine
This is Rietveld 408576698