[Fetch] Request with GET/HEAD method cannot have body

[Fetch] Request with GET/HEAD method cannot have body

BUG=455096, 444493
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189462

[hiroshige, 2015-01-29 13:05:57]

hiroshige@chromium.org changed reviewers:
+ yhirano@chromium.org

[hiroshige, 2015-01-29 13:05:58]

Seems spec was updated after the code.

[hiroshige, 2015-01-29 14:28:08]

hiroshige@chromium.org changed reviewers:
+ horo@chromium.org

[hiroshige, 2015-01-29 14:28:08]

+horo@.

I updated the code according to:
  https://fetch.spec.whatwg.org/#dom-request
  Step 21.1:
  If request's method is `GET` or `HEAD`, throw a TypeError.

However, this CL make the following serviceworker tests:
  serviceworker/cache-delete.html
  serviceworker/cache-put.html
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
(or also
  serviceworker/cache-add.html
  serviceworker/cache-match.html
locally).

At least some tests use Request with 'GET' and body, but I'm not sure how to fix
them correctly.

Any thoughts?

[horo, 2015-02-02 09:32:33]

On 2015/01/29 14:28:08, hiroshige wrote:
> +horo@.
> 
> I updated the code according to:
>   https://fetch.spec.whatwg.org/#dom-request
>   Step 21.1:
>   If request's method is `GET` or `HEAD`, throw a TypeError.
> 
> However, this CL make the following serviceworker tests:
>   serviceworker/cache-delete.html
>   serviceworker/cache-put.html
>
https://storage.googleapis.com/chromium-layout-test-archives/linux_blink_rel/...
> (or also
>   serviceworker/cache-add.html
>   serviceworker/cache-match.html
> locally).
> 
> At least some tests use Request with 'GET' and body, but I'm not sure how to
fix
> them correctly.
> 
> Any thoughts?

Currently cache.add is not supported. And cache.put only supports "GET" method.
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

So plase change the meshod to POST in the tests (ex: new Request('simple.txt',
{body: 'Hello', method: 'POST'});), and change *-expected.txt adding "FAIL ...".

[hiroshige, 2015-02-02 11:41:32]

horo@, thank you for suggestion!
Added method: 'POST' and updated expectations in Patch Set 3.

[horo, 2015-02-02 19:58:37]

lgtm

[yhirano, 2015-02-04 06:12:28]

lgtm

[hiroshige, 2015-02-04 06:16:29]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2015-02-04 06:17:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/882383002/40001

[hiroshige, 2015-02-04 06:32:21]

The CQ bit was unchecked by hiroshige@chromium.org

[hiroshige, 2015-02-04 06:36:33]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2015-02-04 06:37:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/882383002/40001

[commit-bot: I haz the power, 2015-02-04 07:14:21]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189462