Fixed crash when looking for iframe when gaia is being hosted in webview

Fixed crash when looking for iframe when gaia is being hosted in webview

BUG=426316
TEST=manual

Committed: https://crrev.com/3380c8d18be4becbb22fda73c3273555a9ddef98
Cr-Commit-Position: refs/heads/master@{#313701}

[Roman Sorokin (ftl), 2015-01-29 10:41:14]

rsorokin@chromium.org changed reviewers:
+ dpolukhin@chromium.org

[Roman Sorokin (ftl), 2015-01-29 10:41:14]

Dmitry, please review

[Dmitry Polukhin, 2015-01-29 10:51:15]

lgtm

https://codereview.chromium.org/882353002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/signin/inline_login_ui.cc (right):

https://codereview.chromium.org/882353002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/signin/inline_login_ui.cc:101: ||
chromeos::StartupUtils::IsWebviewSigninEnabled()
Could you please instead create boolean variable like this:
bool is_webview = switches::IsEnableWebviewBasedSignin();
#if defined(OS_CHROMEOS)
  is_webview = is_webview || chromeos::StartupUtils::IsWebviewSigninEnabled();
#else

[Roman Sorokin (ftl), 2015-01-29 12:06:08]

rsorokin@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Roman Sorokin (ftl), 2015-01-29 12:06:09]

Nikita, please do owner review

https://codereview.chromium.org/882353002/diff/20001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/signin/inline_login_ui.cc (right):

https://codereview.chromium.org/882353002/diff/20001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/signin/inline_login_ui.cc:101: ||
chromeos::StartupUtils::IsWebviewSigninEnabled()
On 2015/01/29 10:51:15, Dmitry Polukhin wrote:
> Could you please instead create boolean variable like this:
> bool is_webview = switches::IsEnableWebviewBasedSignin();
> #if defined(OS_CHROMEOS)
>   is_webview = is_webview || chromeos::StartupUtils::IsWebviewSigninEnabled();
> #else

Done.

[Dmitry Polukhin, 2015-01-29 12:39:45]

lgtm

[Roman Sorokin (ftl), 2015-01-29 13:11:31]

The CQ bit was checked by rsorokin@chromium.org

[commit-bot: I haz the power, 2015-01-29 13:12:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/882353002/40001

[commit-bot: I haz the power, 2015-01-29 13:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-29 13:18:17]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Nikita (slow), 2015-01-29 14:13:36]

The CQ bit was checked by nkostylev@chromium.org

[Nikita (slow), 2015-01-29 14:13:37]

lgtm

[commit-bot: I haz the power, 2015-01-29 14:14:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/882353002/40001

[commit-bot: I haz the power, 2015-01-29 14:19:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-29 14:20:20]

Patchset 3 (id:??) landed as
https://crrev.com/3380c8d18be4becbb22fda73c3273555a9ddef98
Cr-Commit-Position: refs/heads/master@{#313701}