Issue 882343003: Use the CSS writing-mode rather than the one from VTTCue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882343003: Use the CSS writing-mode rather than the one from VTTCue (Closed)

Created:
5 years, 10 months ago by fs

Modified:
5 years, 10 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, Dominik Röttsches, jchaffraix+rendering

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use the CSS writing-mode rather than the one from VTTCue The DOM element created for a cue box has the writing-mode property applied. This means that the computed style will trivially map to the VTTCue value. Also use the logical* (setLogical*) methods from RenderBox to cut down a bit on the manual handling of the writing mode boilerplate. This makes RenderVTTCue (SnapToLinesLayouter) look more in line with other layout code wrt writing-mode. This eliminates the m_cueWritingDirection state from SnapToLinesLayouter. BUG=301580 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189193

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -25 lines)			Patch
	M	Source/core/rendering/RenderVTTCue.cpp	View		8 chunks	+13 lines, -25 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882343003/1

5 years, 10 months ago (2015-01-29 15:06:33 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-01-29 15:09:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189193

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages