Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 882343002: Upgrade Blink to milliseconds-based last modified filetimes, part 5. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@sof-fileinfo-modtime-in-ms-3
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Upgrade Blink to milliseconds-based last modified filetimes, part 5. Switch Blink to use a milliseconds-based WebFileInfo::modificationTime field instead, leaving the temporary field modificationTimeMS as unused until the embedder has stopped expecting it (see next patch in the series.) With the WebFileInfo switch back to modificationTime, follow up FileMetadata and change its modification time field back to "modificationTime"; it now/still being milliseconds-based. This patch is the fifth one in the following series, 1: [blink] add WebFileInfo::modificationTimeMS [ https://codereview.chromium.org/873723004/ ] 2: [chromium] fill in modificationTimeMS [ https://codereview.chromium.org/884413002/ ] 3: [blink] make use of modificationTimeMS [ https://codereview.chromium.org/884393002/ ] 4: [chromium] set modificationTime to something msec-based [ https://codereview.chromium.org/862203003/ ] 5: [blink] *this one* [ https://codereview.chromium.org/882343002/ ] 6: [chromium] stop setting modificationTimeMS [ https://codereview.chromium.org/890523002/ ] 7: [blink] remove modificationTimeMS [ https://codereview.chromium.org/869613005/ ] R=mkwst BUG=451747 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189838

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M Source/core/fileapi/File.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/forms/FileInputTypeTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/Metadata.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/FileMetadata.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/FileMetadata.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/exported/WebFileSystemCallbacks.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebFileChooserCompletionImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M public/platform/WebFileInfo.h View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Mike West
LGTM.
5 years, 10 months ago (2015-01-30 08:18:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882343002/20001
5 years, 10 months ago (2015-02-09 18:44:47 UTC) #4
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 20:21:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189838

Powered by Google App Engine
This is Rietveld 408576698