Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 882253007: Expose an app_targets variable similar to android_app_targets (Closed)

Created:
5 years, 10 months ago by Daniel Imms
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose an app_targets variable similar to android_app_targets This target provides Chromium embedders with an elegant way to include additional targets for all platforms. BUG=453606 Committed: https://crrev.com/25c9c6c9b35147b4d3e9bababade01d9fe444968 Cr-Commit-Position: refs/heads/master@{#313831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/all.gyp View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Daniel Imms
5 years, 10 months ago (2015-01-29 22:36:20 UTC) #3
cjhopman
lgtm
5 years, 10 months ago (2015-01-29 22:40:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882253007/1
5 years, 10 months ago (2015-01-29 22:52:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 23:52:58 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 23:54:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25c9c6c9b35147b4d3e9bababade01d9fe444968
Cr-Commit-Position: refs/heads/master@{#313831}

Powered by Google App Engine
This is Rietveld 408576698