Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882233003: Label info for webglcontext should have pointer data. (Closed)

Created:
5 years, 10 months ago by sivag
Modified:
5 years, 10 months ago
CC:
bajones, aandrey+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Rik, dglazkov+blink, dshwang, Justin Novosad, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Label info for webglcontext should have pointer data. Along with webgl context naming the context data should also be formatted in the label. BUG=242999 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189388

Patch Set 1 #

Total comments: 2

Patch Set 2 : Patch updated as per review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sivag
Ptal...
5 years, 10 months ago (2015-01-29 17:38:27 UTC) #2
Ken Russell (switch to Gerrit)
Thanks, seems fine. LGTM +a few others in case they see any problem.
5 years, 10 months ago (2015-01-30 19:34:32 UTC) #3
bajones
LGTM, but is there a reason for making it two lines instead of one? String ...
5 years, 10 months ago (2015-01-30 21:53:22 UTC) #5
vmiura
https://codereview.chromium.org/882233003/diff/1/Source/core/html/canvas/WebGLRenderingContext.cpp File Source/core/html/canvas/WebGLRenderingContext.cpp (right): https://codereview.chromium.org/882233003/diff/1/Source/core/html/canvas/WebGLRenderingContext.cpp#newcode126 Source/core/html/canvas/WebGLRenderingContext.cpp:126: context->pushGroupMarkerEXT(contextLabel.utf8().data()); The API expects ASCII encoding, so could you ...
5 years, 10 months ago (2015-01-30 22:08:48 UTC) #7
sivag
ptal.. On 2015/01/30 21:53:22, bajones wrote: > LGTM, but is there a reason for making ...
5 years, 10 months ago (2015-02-02 06:34:36 UTC) #8
bajones
LGTM again
5 years, 10 months ago (2015-02-02 17:48:10 UTC) #9
Ken Russell (switch to Gerrit)
LGTM again too. Feel free to check the "commit" box.
5 years, 10 months ago (2015-02-02 17:56:59 UTC) #10
vmiura
LGTM, thanks.
5 years, 10 months ago (2015-02-02 23:45:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882233003/20001
5 years, 10 months ago (2015-02-03 05:15:48 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 06:33:11 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189388

Powered by Google App Engine
This is Rietveld 408576698