sky/engine/core/rendering/RenderBlock.cpp - Issue 882223005: Remove painting roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RenderBlock.cpp

Issue 882223005: Remove painting roots. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RenderBlock.cpp

diff --git a/sky/engine/core/rendering/RenderBlock.cpp b/sky/engine/core/rendering/RenderBlock.cpp

index 0ec3ad5422fa24218ceb1e047dd309e5b79e378c..103b744c57fe70271ad6fe209ed3826fa1063418 100644

--- a/sky/engine/core/rendering/RenderBlock.cpp

+++ b/sky/engine/core/rendering/RenderBlock.cpp

@@ -479,10 +479,8 @@ void RenderBlock::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset)

void RenderBlock::paintContents(PaintInfo& paintInfo, const LayoutPoint& paintOffset)

{

- // We don't paint our own background, but we do let the kids paint their backgrounds.

- PaintInfo paintInfoForChild(paintInfo);

- paintInfoForChild.updatePaintingRootForChildren(this);

- paintChildren(paintInfoForChild, paintOffset);

+ // FIXME(sky): Can we remove paintContents and just keep paintChildren?

+ paintChildren(paintInfo, paintOffset);

}

void RenderBlock::paintChildren(PaintInfo& paintInfo, const LayoutPoint& paintOffset)

« no previous file with comments | « sky/engine/core/rendering/PaintInfo.h ('k') | sky/engine/core/rendering/RenderBox.cpp » ('j') | no next file with comments »