sky/engine/core/rendering/InlineTextBox.cpp - Issue 882223005: Remove painting roots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/InlineTextBox.cpp

Issue 882223005: Remove painting roots. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/InlineTextBox.cpp

diff --git a/sky/engine/core/rendering/InlineTextBox.cpp b/sky/engine/core/rendering/InlineTextBox.cpp

index 49e359f8c5a3419b8606f016b2596a72eda16251..9cd46d3222c2214a0816b9078cc6f5d8cd5e865d 100644

--- a/sky/engine/core/rendering/InlineTextBox.cpp

+++ b/sky/engine/core/rendering/InlineTextBox.cpp

@@ -480,8 +480,7 @@ void paintTextWithEmphasisMark(

void InlineTextBox::paint(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit /*lineTop*/, LayoutUnit /*lineBottom*/)

{

- if (isLineBreak() || !paintInfo.shouldPaintWithinRoot(&renderer())

- || m_truncation == cFullTruncation || !m_len)

+ if (isLineBreak() || m_truncation == cFullTruncation || !m_len)

return;

LayoutRect logicalVisualOverflow = logicalOverflowRect();