Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5103)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 882193003: Mac: Fix for janky tab dragging/reordering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble
Patch Set: Fix for rsesek Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
index 06492d8374826a4705c62604ac393e8eaa595896..c08665e03d558cce4f8dd62861cf12adbb1134d6 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
@@ -1867,6 +1867,12 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {
}
- (void)mouseMoved:(NSEvent*)event {
+ // We don't want the draggged tab to repeatedly redraw its glow unnecessarily.
+ // We also want the dragged tab to keep the glow even when it slides behind
+ // another tab.
+ if ([dragController_ draggedTab])
+ return;
+
// Use hit test to figure out what view we are hovering over.
NSView* targetView = [tabStripView_ hitTest:[event locationInWindow]];
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698