chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h - Issue 882193003: Mac: Fix for janky tab dragging/reordering.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.h

Issue 882193003: Mac: Fix for janky tab dragging/reordering. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ValidationMessageBubble

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_DRAG_CONTROLLER_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_DRAG_CONTROLLER_H_

6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_DRAG_CONTROLLER_H_	6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_DRAG_CONTROLLER_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9 #include <map>	9 #include <map>

10	10

(...skipping 44 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
55 TabWindowController* draggedController_; // Weak. Controller being dragged.	55 TabWindowController* draggedController_; // Weak. Controller being dragged.

56 NSWindow* dragWindow_; // Weak. The window being dragged	56 NSWindow* dragWindow_; // Weak. The window being dragged

57 NSWindow* dragOverlay_; // Weak. The overlay being dragged	57 NSWindow* dragOverlay_; // Weak. The overlay being dragged

58	58

59 TabWindowController* targetController_; // weak. Controller being targeted	59 TabWindowController* targetController_; // weak. Controller being targeted

60 }	60 }

61	61

62 // Designated initializer.	62 // Designated initializer.

63 - (id)initWithTabStripController:(TabStripController*)controller;	63 - (id)initWithTabStripController:(TabStripController*)controller;

64	64

	65 // The tab being dragged, or nil if not dragging a tab.
	Robert Sesek 2015/01/29 16:13:06 nit: Should come before init. nit: Should come before init. Andre 2015/01/29 17:31:53 Done. Show quoted text On 2015/01/29 16:13:06, Robert Sesek wrote: > nit: Should come before init. Done.
	66 @property(readonly) TabController* draggedTab;

	67

65 // TabDraggingEventTarget methods are also implemented.	68 // TabDraggingEventTarget methods are also implemented.

66	69

67 @end	70 @end

68	71

69 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_DRAG_CONTROLLER_H_	72 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_DRAG_CONTROLLER_H_

OLD	NEW