Issue 882183002: Properly export Master/SlaveConnectionManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882183002: Properly export Master/SlaveConnectionManager. (Closed)

Created:
5 years, 10 months ago by blundell

Modified:
5 years, 10 months ago

Reviewers:
viettrungluu

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Properly export Master/SlaveConnectionManager. Required for the component build in Chromium. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bdd69d7c7d0747d0a3f583567ee24d2866137e92

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -3 lines)			Patch
	M	mojo/edk/system/master_connection_manager.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
	M	mojo/edk/system/slave_connection_manager.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

lgtm (the probability of me forgetting those macros is over 50%)

5 years, 10 months ago (2015-01-28 21:34:56 UTC) #3

blundell

5 years, 10 months ago (2015-01-29 08:06:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bdd69d7c7d0747d0a3f583567ee24d2866137e92 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages