LayoutTests/fast/block/positioning/positioned-movement-layout-when-bottom-changes-to-and-from-auto.html - Issue 882173002: When a positioned object's dependence on content height changes we need to layout.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/block/positioning/positioned-movement-layout-when-bottom-changes-to-and-from-auto.html

Issue 882173002: When a positioned object's dependence on content height changes we need to layout. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/fast/block/positioning/positioned-movement-layout-when-bottom-changes-to-and-from-auto-expected.txt » ('j') | Source/core/rendering/style/RenderStyle.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <style>

	3 body {

	4 margin: 0;

	5 }

	6 #test {

	7 position: absolute;

	8 background-color: green;

	9 top: 0;

	10 left: 0;

	11 right: 0;

	12 }

	13 </style>

	14 <script src="../../../resources/check-layout.js"></script>

	15 <script>

	16
	mstensho (USE GERRIT) 2015/02/02 10:00:47 Superfluous blank line. Superfluous blank line.
	17 function runTest()

	18 {

	19 var test = document.getElementById('test');

	20 document.body.offsetTop;

	21 test.style['bottom'] = '50%';
	mstensho (USE GERRIT) 2015/02/02 10:00:47 Any reason why you shouldn't just let it be '50%' Any reason why you shouldn't just let it be '50%' initially and only change it to 'auto' here?
	22 document.body.offsetTop;

	23 test.style['bottom'] = 'auto';

	24 window.checkLayout("#test");

	25 }

	26 window.onload = runTest;

	27 </script>

	28 <div id="test" data-expected-height=0>
	mstensho (USE GERRIT) 2015/02/02 10:00:47 Strange indentation. Maybe you could also add a c Strange indentation. Maybe you could also add a child with absolute height?
	29 </div>

	30 Tests positioned movement layout when its height is changed by top/bottom changi ng from auto to fixed and back again.
	mstensho (USE GERRIT) 2015/02/02 10:00:47 If you agree to make the change that I suggested a If you agree to make the change that I suggested above, you need to update this text as well. Would probably also look nice if you move this above the DIV.
OLD	NEW