Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 882153006: Fix a crash during aborting of operations on provided file systems. (Closed)

Created:
5 years, 10 months ago by mtomasz
Modified:
5 years, 10 months ago
Reviewers:
hirono
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a crash during aborting of operations on provided file systems. In case of an abort, a memory corruption was occuring because of a call to Queue::Complete() after an operation is aborted, which is invalid according to both documentation and a DCHECK. This CL fixes the issue by avoiding calling Queue::Complete() for aborted tasks. TEST=Tested manually. Try to copy files from a ZIP archive with thousands of files, and abort during the operation. BUG=454310 Committed: https://crrev.com/33176770fd2364913cb17f251315192b8bf593da Cr-Commit-Position: refs/heads/master@{#314722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/chromeos/file_system_provider/throttled_file_system.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@hirono: PTAL. Thanks.
5 years, 10 months ago (2015-02-04 11:49:36 UTC) #2
hirono
lgtm!
5 years, 10 months ago (2015-02-05 02:16:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882153006/1
5 years, 10 months ago (2015-02-05 02:18:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 02:22:12 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 02:23:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33176770fd2364913cb17f251315192b8bf593da
Cr-Commit-Position: refs/heads/master@{#314722}

Powered by Google App Engine
This is Rietveld 408576698