Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882153005: Fix a null ptr deref crash in DesktopCaptureDevice (Closed)

Created:
5 years, 10 months ago by jiayl
Modified:
5 years, 10 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a null ptr deref crash in DesktopCaptureDevice BUG=450382 Committed: https://crrev.com/ca020c9cc7be20b3bea523ddad8f114e167af0a7 Cr-Commit-Position: refs/heads/master@{#314377}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M content/browser/media/capture/desktop_capture_device.cc View 1 2 3 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jiayl
PTAL
5 years, 10 months ago (2015-02-03 17:44:23 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/882153005/diff/1/content/browser/media/capture/desktop_capture_device.cc File content/browser/media/capture/desktop_capture_device.cc (right): https://codereview.chromium.org/882153005/diff/1/content/browser/media/capture/desktop_capture_device.cc#newcode470 content/browser/media/capture/desktop_capture_device.cc:470: if (thread_.message_loop_proxy()) { I'd prefer checking that core_ is ...
5 years, 10 months ago (2015-02-03 17:49:19 UTC) #3
jiayl
ptal https://codereview.chromium.org/882153005/diff/1/content/browser/media/capture/desktop_capture_device.cc File content/browser/media/capture/desktop_capture_device.cc (right): https://codereview.chromium.org/882153005/diff/1/content/browser/media/capture/desktop_capture_device.cc#newcode470 content/browser/media/capture/desktop_capture_device.cc:470: if (thread_.message_loop_proxy()) { On 2015/02/03 17:49:18, Sergey Ulanov ...
5 years, 10 months ago (2015-02-03 17:54:10 UTC) #4
Sergey Ulanov
lgtm https://codereview.chromium.org/882153005/diff/20001/content/browser/media/capture/desktop_capture_device.cc File content/browser/media/capture/desktop_capture_device.cc (right): https://codereview.chromium.org/882153005/diff/20001/content/browser/media/capture/desktop_capture_device.cc#newcode470 content/browser/media/capture/desktop_capture_device.cc:470: if (core_) { nit: This can be more ...
5 years, 10 months ago (2015-02-03 18:15:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882153005/40001
5 years, 10 months ago (2015-02-03 18:17:02 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 19:06:04 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:07:04 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/ca020c9cc7be20b3bea523ddad8f114e167af0a7
Cr-Commit-Position: refs/heads/master@{#314377}

Powered by Google App Engine
This is Rietveld 408576698