Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 882153004: Re-enable main-frame and subframe CSSOM smooth scroll layout tests (Closed)

Created:
5 years, 10 months ago by ajuma
Modified:
5 years, 10 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-enable main-frame and subframe CSSOM smooth scroll layout tests This re-enables tests that were disabled when the ScrollTopLeftInterop runtime-enabled feature was disabled for tests in http://crrev.com/891523002. Tests that previously scrolled the document element now scroll the body element, and FrameView::setScrollPosition now checks the scroll-behavior property on the body element rather than on the document element. BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189512

Patch Set 1 #

Total comments: 2

Patch Set 2 : Choose body or documentElement based on ScrollTopLeftInterop #

Patch Set 3 : Rebased #

Patch Set 4 : Use nullptr instead of 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -73 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-element-scroll.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-element-scrollBy.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-element-scrollTo.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-interrupted-scroll.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scroll.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollBy.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollLeft.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollTo.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/main-frame-scrollTop.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-element-scroll.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-element-scrollBy.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-element-scrollTo.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-interrupted-scroll.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scroll.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollBy.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollLeft.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollTo.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/scroll-behavior/subframe-scrollTop.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
ajuma
5 years, 10 months ago (2015-02-03 19:13:04 UTC) #2
skobes
lgtm
5 years, 10 months ago (2015-02-03 19:32:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882153004/1
5 years, 10 months ago (2015-02-03 19:34:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/25637)
5 years, 10 months ago (2015-02-03 19:41:28 UTC) #7
ajuma
jochen, PTAL for core/ OWNERS.
5 years, 10 months ago (2015-02-03 19:42:22 UTC) #8
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-04 12:48:50 UTC) #9
jochen (gone - plz use gerrit)
https://codereview.chromium.org/882153004/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/882153004/diff/1/Source/core/frame/FrameView.cpp#newcode1556 Source/core/frame/FrameView.cpp:1556: RenderObject* renderer = m_frame->document()->body() ? m_frame->document()->body()->renderer() : 0; should ...
5 years, 10 months ago (2015-02-04 12:49:17 UTC) #10
ajuma
https://codereview.chromium.org/882153004/diff/1/Source/core/frame/FrameView.cpp File Source/core/frame/FrameView.cpp (right): https://codereview.chromium.org/882153004/diff/1/Source/core/frame/FrameView.cpp#newcode1556 Source/core/frame/FrameView.cpp:1556: RenderObject* renderer = m_frame->document()->body() ? m_frame->document()->body()->renderer() : 0; On ...
5 years, 10 months ago (2015-02-04 15:08:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882153004/60001
5 years, 10 months ago (2015-02-04 15:16:41 UTC) #14
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 17:03:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189512

Powered by Google App Engine
This is Rietveld 408576698