Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 882123004: Renamed v4l2_video_device.*->v4l2_device.* and generic_v4l2_video_device.*->generic_v4l2_device.* a… (Closed)

Created:
5 years, 10 months ago by emircan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed v4l2_video_device.*->v4l2_device.* and generic_v4l2_video_device.*->generic_v4l2_device.* and tegra_v4l2_video_device.*->tegra_v4l2_device.* to be consistent with class names. BUG=453934 TEST=Built and deployed on peach_pi. AppRTC loopback and VEA test works fine. Committed: https://crrev.com/2090fc2bec6d9600e5d0847e0fe761e3497d7576 Cr-Commit-Position: refs/heads/master@{#318255}

Patch Set 1 #

Patch Set 2 : Added back the missing include header and rebased. #

Patch Set 3 : Changed the include to updated file name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -992 lines) Patch
M content/common/BUILD.gn View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + content/common/gpu/media/generic_v4l2_device.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + content/common/gpu/media/generic_v4l2_device.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/media/generic_v4l2_video_device.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/common/gpu/media/generic_v4l2_video_device.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + content/common/gpu/media/tegra_v4l2_device.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + content/common/gpu/media/tegra_v4l2_device.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/media/tegra_v4l2_video_device.h View 1 chunk +0 lines, -59 lines 0 comments Download
D content/common/gpu/media/tegra_v4l2_video_device.cc View 1 chunk +0 lines, -223 lines 0 comments Download
A + content/common/gpu/media/v4l2_device.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/gpu/media/v4l2_device.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/media/v4l2_image_processor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_slice_video_decode_accelerator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/v4l2_video_decode_accelerator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/media/v4l2_video_device.h View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
D content/common/gpu/media/v4l2_video_device.cc View 1 chunk +0 lines, -205 lines 0 comments Download
M content/common/gpu/media/v4l2_video_encode_accelerator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 2 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
emircan
BAsed on the suggestions at https://code.google.com/p/chromium/issues/detail?id=453934 PTAL
5 years, 10 months ago (2015-02-02 22:30:50 UTC) #2
Pawel Osciak
On 2015/02/02 22:30:50, emircan wrote: > BAsed on the suggestions at > https://code.google.com/p/chromium/issues/detail?id=453934 > > ...
5 years, 10 months ago (2015-02-04 10:20:27 UTC) #4
emircan
This CL is basically changing file names and class names, so I did a build ...
5 years, 10 months ago (2015-02-06 01:30:09 UTC) #5
emircan
I updated the TEST line with my tests. I had to go through couple merge ...
5 years, 10 months ago (2015-02-11 03:06:43 UTC) #8
Pawel Osciak
lgtm%nit https://chromiumcodereview.appspot.com/882123004/diff/60001/content/common/gpu/media/video_decode_accelerator_unittest.cc File content/common/gpu/media/video_decode_accelerator_unittest.cc (left): https://chromiumcodereview.appspot.com/882123004/diff/60001/content/common/gpu/media/video_decode_accelerator_unittest.cc#oldcode65 content/common/gpu/media/video_decode_accelerator_unittest.cc:65: #include "content/common/gpu/media/v4l2_video_device.h" I think we'd still prefer to ...
5 years, 10 months ago (2015-02-13 01:10:44 UTC) #9
emircan
On 2015/02/13 01:10:44, Pawel Osciak wrote: > lgtm%nit > > https://chromiumcodereview.appspot.com/882123004/diff/60001/content/common/gpu/media/video_decode_accelerator_unittest.cc > File content/common/gpu/media/video_decode_accelerator_unittest.cc (left): ...
5 years, 10 months ago (2015-02-18 22:03:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882123004/80001
5 years, 10 months ago (2015-02-18 22:04:45 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/43636)
5 years, 10 months ago (2015-02-18 22:15:01 UTC) #16
emircan
CQ failed as I needed approval from BUILD owner. I added jln@ as a reviewer. ...
5 years, 10 months ago (2015-02-18 22:56:42 UTC) #18
emircan
On 2015/02/18 22:56:42, emircan wrote: > CQ failed as I needed approval from BUILD owner. ...
5 years, 9 months ago (2015-02-26 00:37:11 UTC) #20
Avi (use Gerrit)
lgtm If it's just a rename, you're fine.
5 years, 9 months ago (2015-02-26 16:21:52 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882123004/80001
5 years, 9 months ago (2015-02-26 17:04:22 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:80001)
5 years, 9 months ago (2015-02-26 17:50:50 UTC) #24
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 17:51:42 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2090fc2bec6d9600e5d0847e0fe761e3497d7576
Cr-Commit-Position: refs/heads/master@{#318255}

Powered by Google App Engine
This is Rietveld 408576698