Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 882113003: [Mac] Always use the small, non-high res default avatars in the People menu bar (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Always use the small, non-high res default avatars in the People menu bar BUG=447311 TEST=Start Chrome. Click on the "People" menu in the OS menu bar. Any profiles with default avatar should display the low res, transparent background images (i.e. not the high res images with the grey background) Committed: https://crrev.com/a6eadfffa64f816048e85991b544beac0ab164d0 Cr-Commit-Position: refs/heads/master@{#313544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
noms (inactive)
PTAL
5 years, 10 months ago (2015-01-28 16:30:17 UTC) #2
Alexei Svitkine (slow)
Would this result in pixelated images on a retina display?
5 years, 10 months ago (2015-01-28 16:49:12 UTC) #3
chromium-reviews
Nope! This just uses the old avatar icons, and they come in 1x and 2x ...
5 years, 10 months ago (2015-01-28 17:01:25 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 10 months ago (2015-01-28 17:35:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882113003/1
5 years, 10 months ago (2015-01-28 17:39:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 18:33:29 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 18:34:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6eadfffa64f816048e85991b544beac0ab164d0
Cr-Commit-Position: refs/heads/master@{#313544}

Powered by Google App Engine
This is Rietveld 408576698