Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 882083003: Remove mojo.SurfacesService interface in favor of mojo.Surface directly (Closed)

Created:
5 years, 10 months ago by jamesr
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove mojo.SurfacesService interface in favor of mojo.Surface directly Most of the callers have been updated to the new flow already. This updates the rest and removes the deprecated interface to simplify the flows in preparation for de-Clienting this interface. Chromium caller updated to not use this interface here: https://codereview.chromium.org/869343004/ R=sky@chromium.org BUG=451319 Committed: https://chromium.googlesource.com/external/mojo/+/69fc5685f1b3acbf011cbc7af162f704657b184f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -154 lines) Patch
M examples/bitmap_uploader/bitmap_uploader.h View 1 chunk +0 lines, -1 line 0 comments Download
M examples/surfaces_app/child_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/surfaces/public/interfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/services/surfaces/public/interfaces/surfaces_service.mojom View 1 chunk +0 lines, -15 lines 0 comments Download
M services/fake_surfaces/fake_surfaces_service_application.h View 3 chunks +1 line, -6 lines 0 comments Download
M services/fake_surfaces/fake_surfaces_service_application.cc View 2 chunks +1 line, -32 lines 0 comments Download
M services/native_viewport/viewport_surface.h View 1 chunk +0 lines, -1 line 0 comments Download
M services/surfaces/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/surfaces/surfaces_service_application.h View 3 chunks +0 lines, -6 lines 0 comments Download
M services/surfaces/surfaces_service_application.cc View 2 chunks +1 line, -9 lines 0 comments Download
D services/surfaces/surfaces_service_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D services/surfaces/surfaces_service_impl.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M services/view_manager/display_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/compositor/surface_holder.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
5 years, 10 months ago (2015-01-30 01:35:57 UTC) #1
sky
LGTM
5 years, 10 months ago (2015-01-30 18:24:37 UTC) #2
jamesr
5 years, 10 months ago (2015-01-30 21:02:53 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
69fc5685f1b3acbf011cbc7af162f704657b184f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698