Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 882073002: Route resource dispatch tasks via the loading task queue (Closed)

Created:
5 years, 10 months ago by alex clarke (OOO till 29th)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, picksi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Route resource dispatch tasks via the loading task queue This patch should make the main thread more responsive when the user is interacting with the device while the page is loading. Sherrifs if you see an uptick in blink layout test flakes this patch might be to blame. I tried to reproduce the flakes I saw in the try runs locally. With the exception of fast/loader/subframe-removes-itself.html I was not able to reproduce a flake, however judging by the flakiness dashboard, that test is already slightly flaky. BUG=391005 Committed: https://crrev.com/1838a81f74e6ef7a6cc9296bfec20ea1f0ff97a1 Cr-Commit-Position: refs/heads/master@{#313739}

Patch Set 1 #

Patch Set 2 : Set the IPC Sync Chnnel listener task runner to be the loading task queue too #

Patch Set 3 : Don't set the ipc sync channel's listener #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M content/renderer/render_thread_impl.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
alex clarke (OOO till 29th)
5 years, 10 months ago (2015-01-28 11:18:55 UTC) #2
alex clarke (OOO till 29th)
On 2015/01/28 11:18:55, alexclarke1 wrote: Looks like this patch may not go far enough, just ...
5 years, 10 months ago (2015-01-28 12:20:13 UTC) #3
alex clarke (OOO till 29th)
I've set the IPC Sync Thread's listener task runner to be the loading task queue ...
5 years, 10 months ago (2015-01-28 13:26:50 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-01-28 19:00:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882073002/20001
5 years, 10 months ago (2015-01-29 11:19:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/49220)
5 years, 10 months ago (2015-01-29 12:13:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882073002/20001
5 years, 10 months ago (2015-01-29 14:37:32 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/19526)
5 years, 10 months ago (2015-01-29 15:27:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882073002/40001
5 years, 10 months ago (2015-01-29 17:34:02 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 18:25:37 UTC) #16
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 18:26:31 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1838a81f74e6ef7a6cc9296bfec20ea1f0ff97a1
Cr-Commit-Position: refs/heads/master@{#313739}

Powered by Google App Engine
This is Rietveld 408576698