Issue 882063007: Improve consistency between event sources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 882063007: Improve consistency between event sources. (Closed)

Created:
5 years, 10 months ago by Jamie

Modified:
5 years, 10 months ago

Reviewers:
kelvinp

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Improve consistency between event sources. * Add keypress JS event handler * Change some keycode->name conversions to match what we get from NaCl This CL also bumps the version number since I've already pushed v1.0 to CWS. Committed: https://crrev.com/3ee370ba9dd89a99a8c33c717473112627ce0257 Cr-Commit-Position: refs/heads/master@{#314947}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -57 lines)			Patch
M	remoting/tools/javascript_key_tester/event_listeners.js	View	4 chunks	+14 lines, -0 lines	0 comments	Download
M	remoting/tools/javascript_key_tester/keyboard_map.js	View	3 chunks	+56 lines, -56 lines	0 comments	Download
M	remoting/tools/javascript_key_tester/manifest.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882063007/1

5 years, 10 months ago (2015-02-06 01:49:42 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-06 02:16:36 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3ee370ba9dd89a99a8c33c717473112627ce0257
Cr-Commit-Position: refs/heads/master@{#314947}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages