Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 882063004: aw: Auto prepend http scheme in test shell (Closed)

Created:
5 years, 10 months ago by boliu
Modified:
5 years, 10 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aw: Auto prepend http scheme in test shell This has confused more than one person using the shell for the first time. BUG= Committed: https://crrev.com/6c46080bac609fe3df0701b403709559c8ff4b4e Cr-Commit-Position: refs/heads/master@{#314652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 2 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
boliu
ptal
5 years, 10 months ago (2015-02-04 19:48:57 UTC) #2
sgurun-gerrit only
On 2015/02/04 19:48:57, boliu wrote: > ptal lgtm
5 years, 10 months ago (2015-02-04 21:45:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882063004/1
5 years, 10 months ago (2015-02-04 21:48:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 22:09:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 22:10:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c46080bac609fe3df0701b403709559c8ff4b4e
Cr-Commit-Position: refs/heads/master@{#314652}

Powered by Google App Engine
This is Rietveld 408576698