Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 882063002: [turbofan] Use unboxed doubles in range types. (Closed)

Created:
5 years, 10 months ago by Jarin
Modified:
5 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use unboxed doubles in range types. BUG= R=bmeurer@chromium.org Committed: https://crrev.com/3c9f98516c5751fc228316559b28cd6ab8f7db77 Cr-Commit-Position: refs/heads/master@{#26307}

Patch Set 1 #

Patch Set 2 : Make tests less fragile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -232 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +7 lines, -10 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/typer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/typer.cc View 21 chunks +45 lines, -61 lines 0 comments Download
M src/types.h View 1 15 chunks +72 lines, -34 lines 0 comments Download
M src/types.cc View 15 chunks +27 lines, -38 lines 0 comments Download
M src/types-inl.h View 9 chunks +125 lines, -1 line 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 2 chunks +4 lines, -10 lines 0 comments Download
M test/cctest/compiler/test-typer.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M test/cctest/test-types.cc View 1 12 chunks +35 lines, -38 lines 0 comments Download
M test/cctest/types-fuzz.h View 3 chunks +5 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 12 chunks +10 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jarin
Could you take a look, please?
5 years, 10 months ago (2015-01-28 10:42:02 UTC) #1
Benedikt Meurer
LGTM
5 years, 10 months ago (2015-01-28 13:25:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882063002/20001
5 years, 10 months ago (2015-01-28 13:25:59 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-28 13:55:45 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 13:55:55 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3c9f98516c5751fc228316559b28cd6ab8f7db77
Cr-Commit-Position: refs/heads/master@{#26307}

Powered by Google App Engine
This is Rietveld 408576698