Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 882053002: MacViews: Move ui_control_mac's anon::SynthesizeKeyEvent() to cocoa_test_event_utils.h (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MacViews: Move ui_control_mac's anon::SynthesizeKeyEvent() to cocoa_test_event_utils.h ui_controls functions are typically only used in interactive_ui_tests since it's not supported in sharded test suites. We want to use its SynthesizeKeyEvent() to generate events in event_generator_delegate_mac.mm (which is designed for non-interactive tests and can be sharded). This CL moves it to cocoa_test_event_utils.h BUG=378134 Committed: https://crrev.com/332e948d08ddf9522f4132f71dd6120bd3d7deaf Cr-Commit-Position: refs/heads/master@{#314243}

Patch Set 1 #

Patch Set 2 : less needs to move now #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -96 lines) Patch
M ui/base/test/ui_controls_mac.mm View 3 chunks +4 lines, -96 lines 0 comments Download
M ui/events/test/cocoa_test_event_utils.h View 2 chunks +10 lines, -0 lines 0 comments Download
M ui/events/test/cocoa_test_event_utils.mm View 2 chunks +99 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi sadrul, this is the boring function-move, split out from http://crrev.com/879253002 . Since you were ...
5 years, 10 months ago (2015-02-02 22:50:55 UTC) #2
sadrul
lgtm
5 years, 10 months ago (2015-02-03 01:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882053002/20001
5 years, 10 months ago (2015-02-03 01:42:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 02:10:40 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 02:11:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/332e948d08ddf9522f4132f71dd6120bd3d7deaf
Cr-Commit-Position: refs/heads/master@{#314243}

Powered by Google App Engine
This is Rietveld 408576698