Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 882043006: Prevent single-app kiosk mode auto-launch if device is disabled (Closed)

Created:
5 years, 10 months ago by bartfab (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent single-app kiosk mode auto-launch if device is disabled If a device is disabled, it should show the disabled screen and not start any sessions. Regular sessions, auto-launch for public sessions and auto-launch for consumer kiosk mode respected this. Auto-launch for enterprise kiosk mode takes a different code path that had slipped through the cracks. The effect was that single-app kiosk mode would auto-launch even if a device was disabled. BUG=454005 TEST=New browser test Committed: https://crrev.com/0ec3b217448a4c76a77c43e558687df18a61c20e Cr-Commit-Position: refs/heads/master@{#314330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -8 lines) Patch
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 9 chunks +95 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 3 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bartfab (slow)
Hi Denis, Could you take a look please?
5 years, 10 months ago (2015-02-02 19:19:18 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm
5 years, 10 months ago (2015-02-03 13:44:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/882043006/1
5 years, 10 months ago (2015-02-03 14:06:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 14:51:35 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 14:52:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ec3b217448a4c76a77c43e558687df18a61c20e
Cr-Commit-Position: refs/heads/master@{#314330}

Powered by Google App Engine
This is Rietveld 408576698