Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: chrome/browser/chromeos/attestation/platform_verification_dialog.h

Issue 881983003: media: Invoke PlatformVerificationDialog from ProtectedMediaIdentifierPermissionContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/attestation/platform_verification_dialog.h
diff --git a/chrome/browser/chromeos/attestation/platform_verification_dialog.h b/chrome/browser/chromeos/attestation/platform_verification_dialog.h
index e33ebd0e9fd2f4255158f7c7e9b3059b196074aa..2dd6e2f9c39686fab7ee8c063abdd41300658257 100644
--- a/chrome/browser/chromeos/attestation/platform_verification_dialog.h
+++ b/chrome/browser/chromeos/attestation/platform_verification_dialog.h
@@ -26,8 +26,12 @@ class PlatformVerificationDialog : public views::DialogDelegateView,
public content::WebContentsObserver {
public:
// Initializes a tab-modal dialog for |web_contents| and shows it.
- static void ShowDialog(
+ // Returns a non-owning pointer to the widget so that caller can close the
+ // dialog and cancel the request. The returned widget is only guaranteed to be
+ // valid before |callback| is called.
+ static views::Widget* ShowDialog(
content::WebContents* web_contents,
+ const GURL& requesting_origin,
Darren Krahn 2015/02/05 16:40:44 nit: undocumented arg Also, this means the dialog
xhwang 2015/02/05 18:09:48 Done.
const PlatformVerificationFlow::Delegate::ConsentCallback& callback);
protected:

Powered by Google App Engine
This is Rietveld 408576698