Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 881973002: Captive portal interstitial: Use the same string for page title and header. (Closed)

Created:
5 years, 10 months ago by meacer
Modified:
5 years, 10 months ago
Reviewers:
felt
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Captive portal interstitial: Use the same string for page title and header. I've noticed that the localization of the strings are done differently, so it's better to use the same string for both. BUG= Committed: https://crrev.com/efce41c38545a466b6b1424cabdd741025a58990 Cr-Commit-Position: refs/heads/master@{#313602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ssl/captive_portal_blocking_page.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
meacer
felt: Can you PTAL? Thanks.
5 years, 10 months ago (2015-01-28 01:18:45 UTC) #2
felt
On 2015/01/28 01:18:45, Mustafa Emre Acer wrote: > felt: Can you PTAL? Thanks. This seems ...
5 years, 10 months ago (2015-01-28 15:10:40 UTC) #3
meacer
On 2015/01/28 15:10:40, felt wrote: > On 2015/01/28 01:18:45, Mustafa Emre Acer wrote: > > ...
5 years, 10 months ago (2015-01-28 18:11:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881973002/1
5 years, 10 months ago (2015-01-28 21:35:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 22:57:46 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 22:59:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efce41c38545a466b6b1424cabdd741025a58990
Cr-Commit-Position: refs/heads/master@{#313602}

Powered by Google App Engine
This is Rietveld 408576698