cc/output/gl_renderer.cc - Issue 881963002: Clamp YUV videos to their visible size in the shader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.cc

Issue 881963002: Clamp YUV videos to their visible size in the shader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/gl_renderer.cc

diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc

index 9c856e86786c523939dff2e69ee49491000f99cb..2c3bd13d014339f5ef0e7ce3f820474296ba00dd 100644

--- a/cc/output/gl_renderer.cc

+++ b/cc/output/gl_renderer.cc

@@ -1832,6 +1832,7 @@ void GLRenderer::DrawYUVVideoQuad(const DrawingFrame* frame,

int matrix_location = -1;

int tex_scale_location = -1;

int tex_offset_location = -1;

+ int clamp_size_location = -1;

int y_texture_location = -1;

int u_texture_location = -1;

int v_texture_location = -1;

@@ -1846,6 +1847,7 @@ void GLRenderer::DrawYUVVideoQuad(const DrawingFrame* frame,

matrix_location = program->vertex_shader().matrix_location();

tex_scale_location = program->vertex_shader().tex_scale_location();

tex_offset_location = program->vertex_shader().tex_offset_location();

+ clamp_size_location = program->vertex_shader().clamp_size_location();

y_texture_location = program->fragment_shader().y_texture_location();

u_texture_location = program->fragment_shader().u_texture_location();

v_texture_location = program->fragment_shader().v_texture_location();

@@ -1860,6 +1862,7 @@ void GLRenderer::DrawYUVVideoQuad(const DrawingFrame* frame,

matrix_location = program->vertex_shader().matrix_location();

tex_scale_location = program->vertex_shader().tex_scale_location();

tex_offset_location = program->vertex_shader().tex_offset_location();

+ clamp_size_location = program->vertex_shader().clamp_size_location();

y_texture_location = program->fragment_shader().y_texture_location();

u_texture_location = program->fragment_shader().u_texture_location();

v_texture_location = program->fragment_shader().v_texture_location();

@@ -1876,6 +1879,9 @@ void GLRenderer::DrawYUVVideoQuad(const DrawingFrame* frame,

gl_->Uniform2f(tex_offset_location,

quad->tex_coord_rect.x(),

quad->tex_coord_rect.y()));

+ GLC(gl_, gl_->Uniform2f(clamp_size_location, quad->clamp_size.width(),

+ quad->clamp_size.height()));

GLC(gl_, gl_->Uniform1i(y_texture_location, 1));

GLC(gl_, gl_->Uniform1i(u_texture_location, 2));

GLC(gl_, gl_->Uniform1i(v_texture_location, 3));

« no previous file with comments | « cc/layers/video_layer_impl.cc ('k') | cc/output/renderer_pixeltest.cc » ('j') | cc/output/shader.cc » ('J')