Issue 881953002: patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 881953002: patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001) (Closed)

Created:
5 years, 11 months ago by mtklein_C

Modified:
5 years, 11 months ago

Reviewers:
mtklein

CC:
herb, reed1, hal.canary, reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

patch from issue 885453002 at patchset 20001 (http://crrev.com/885453002#ps20001) Make the char cache dynamic in SkGlyphCache because it is rarely used. Landing on behalf of Herb. BUG=skia: Committed: https://skia.googlesource.com/skia/+/95faa61d63a6f62916f6f7be58c4624da8357e3b

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
	M	src/core/SkGlyphCache.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	src/core/SkGlyphCache.cpp	View		7 chunks	+17 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881953002/1

5 years, 11 months ago (2015-01-27 23:04:52 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/95faa61d63a6f62916f6f7be58c4624da8357e3b

5 years, 11 months ago (2015-01-27 23:10:21 UTC) #5

mtklein

5 years, 11 months ago (2015-01-27 23:38:22 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/881023003/ by mtklein@google.com.

The reason for reverting is: ==32435==ERROR: AddressSanitizer:
alloc-dealloc-mismatch (operator new [] vs operator delete) on 0x621000d8cd00

Lots of info here:
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x....

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages