Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 881933004: Mojo+NaCl: Move generated code to mojo/nacl. (Closed)

Created:
5 years, 10 months ago by teravest
Modified:
5 years, 10 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo+NaCl: Move generated code to mojo/nacl. This change moves generated code for Mojo support in NaCl from mojo/monacl to mojo/nacl. This makes the target directory more consistent across GYP and GN builds. An upcoming change for IRT support will generate a header, which will need a consistent path (relative to include_dirs) across build systems. An earlier version of this change failed to update mojo/mojo_nacl_untrusted.gyp, causing clean builds to fail. I've confirmed that this change builds correctly with a clean build. BUG=454466 TEST=clobber, then build Committed: https://crrev.com/8802d7dd2d30ca90dc834089cb871c5f68b76343 Cr-Commit-Position: refs/heads/master@{#314811}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -12 lines) Patch
M mojo/mojo_nacl.gyp View 1 chunk +1 line, -3 lines 0 comments Download
A + mojo/mojo_nacl.gypi View 1 chunk +4 lines, -6 lines 0 comments Download
M mojo/mojo_nacl_untrusted.gyp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
teravest
5 years, 10 months ago (2015-02-04 21:10:46 UTC) #2
jamesr
lgtm
5 years, 10 months ago (2015-02-04 23:22:01 UTC) #3
Nick Bray (chromium)
General LGTM. Relying on Jame's and your judgement for the details, not functioning 100% right ...
5 years, 10 months ago (2015-02-04 23:34:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881933004/1
5 years, 10 months ago (2015-02-05 15:21:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-05 15:25:52 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 15:26:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8802d7dd2d30ca90dc834089cb871c5f68b76343
Cr-Commit-Position: refs/heads/master@{#314811}

Powered by Google App Engine
This is Rietveld 408576698