Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 881903002: [fsp] Add an information that root entry name should be an empty string (Closed)

Created:
5 years, 10 months ago by mtomasz
Modified:
5 years, 10 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Add an information that root entry name should be an empty string Before, it was not well defined what's the name of a root entry. TEST=None BUG=446437 Committed: https://crrev.com/916c3afeac23071ede96c90a0c4df4988f6df11f Cr-Commit-Position: refs/heads/master@{#313379}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typo :( #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/common/extensions/api/file_system_provider.idl View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
mtomasz
@benwells: PTAL. Thanks.
5 years, 10 months ago (2015-01-27 20:42:25 UTC) #2
benwells
lgtm with the typo corrected. https://codereview.chromium.org/881903002/diff/1/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/881903002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode50 chrome/common/extensions/api/file_system_provider.idl:50: // is must be ...
5 years, 10 months ago (2015-01-27 21:07:54 UTC) #3
mtomasz
https://codereview.chromium.org/881903002/diff/1/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/881903002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode50 chrome/common/extensions/api/file_system_provider.idl:50: // is must be empty. On 2015/01/27 21:07:54, benwells ...
5 years, 10 months ago (2015-01-27 21:42:54 UTC) #4
mtomasz
https://codereview.chromium.org/881903002/diff/1/chrome/common/extensions/api/file_system_provider.idl File chrome/common/extensions/api/file_system_provider.idl (right): https://codereview.chromium.org/881903002/diff/1/chrome/common/extensions/api/file_system_provider.idl#newcode50 chrome/common/extensions/api/file_system_provider.idl:50: // is must be empty. On 2015/01/27 21:07:54, benwells ...
5 years, 10 months ago (2015-01-27 21:42:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881903002/20001
5 years, 10 months ago (2015-01-27 21:43:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-27 22:29:26 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 22:30:20 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/916c3afeac23071ede96c90a0c4df4988f6df11f
Cr-Commit-Position: refs/heads/master@{#313379}

Powered by Google App Engine
This is Rietveld 408576698