Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 881893004: Hook SetKeyOnIO in Webview to DataReductionProxyIOData (Closed)

Created:
5 years, 10 months ago by bengr
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook SetKeyOnIO in Webview to DataReductionProxyIOData AwURLRequestContextGetter::SetKeyOnIO now calls into the DataReductionProxyAuthRequestHandler that is managed by DataReductionProxyIOData. BUG=453519 Committed: https://crrev.com/76b3a496ce4e6da8779cd408202fe7e0f6edda46 Cr-Commit-Position: refs/heads/master@{#315119}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -24 lines) Patch
M android_webview/browser/net/aw_url_request_context_getter.h View 3 chunks +0 lines, -9 lines 0 comments Download
M android_webview/browser/net/aw_url_request_context_getter.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M android_webview/native/aw_contents_statics.cc View 3 chunks +1 line, -4 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
bengr
sgurun: aw
5 years, 10 months ago (2015-02-05 18:24:08 UTC) #3
bengr
And sclittle: components/*
5 years, 10 months ago (2015-02-05 18:24:39 UTC) #5
sgurun-gerrit only
On 2015/02/05 18:24:39, bengr wrote: > And sclittle: components/* can we write a test for ...
5 years, 10 months ago (2015-02-05 18:42:53 UTC) #6
sclittle
On 2015/02/05 18:42:53, sgurun wrote: > On 2015/02/05 18:24:39, bengr wrote: > > And sclittle: ...
5 years, 10 months ago (2015-02-05 19:27:18 UTC) #7
bengr
On 2015/02/05 19:27:18, sclittle wrote: > On 2015/02/05 18:42:53, sgurun wrote: > > On 2015/02/05 ...
5 years, 10 months ago (2015-02-06 00:31:45 UTC) #8
sgurun-gerrit only
On 2015/02/06 00:31:45, bengr wrote: > On 2015/02/05 19:27:18, sclittle wrote: > > On 2015/02/05 ...
5 years, 10 months ago (2015-02-06 18:15:37 UTC) #9
sclittle
LGTM
5 years, 10 months ago (2015-02-06 18:23:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881893004/2
5 years, 10 months ago (2015-02-06 21:56:00 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:2)
5 years, 10 months ago (2015-02-06 22:00:03 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 22:00:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76b3a496ce4e6da8779cd408202fe7e0f6edda46
Cr-Commit-Position: refs/heads/master@{#315119}

Powered by Google App Engine
This is Rietveld 408576698