Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 881863002: Revert of Revert of Enable ChannelMojo (Closed)

Created:
5 years, 10 months ago by Hajime Morrita
Modified:
5 years, 10 months ago
Reviewers:
yoichio, viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Enable ChannelMojo (patchset #1 id:1 of https://codereview.chromium.org/875333002/) Reason for revert: This revert was innocent. The culprit was https://codereview.chromium.org/878843002/ Original issue's description: > Revert of Enable ChannelMojo (patchset #3 id:40001 of https://codereview.chromium.org/857483004/) > > Reason for revert: > many ipc test failed. > https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/10036 > > Original issue's description: > > Enable ChannelMojo > > > > As we addressed certain amount of the performance problem, > > it's time to give it another try. > > > > R=viettrungluu@chromium.org > > BUG=377980 > > > > Committed: https://crrev.com/a06cd1b2fe83b51b0874ca504066f00a17192026 > > Cr-Commit-Position: refs/heads/master@{#313184} > > TBR=viettrungluu@chromium.org,morrita@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=377980 > > Committed: https://crrev.com/af01416ada7b968c55224be9e61272ad73e59fe1 > Cr-Commit-Position: refs/heads/master@{#313225} TBR=viettrungluu@chromium.org,yoichio@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=377980 Committed: https://crrev.com/599be60af8d7643966e26fe631768e4a5c99e991 Cr-Commit-Position: refs/heads/master@{#313318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Hajime Morrita
Created Revert of Revert of Enable ChannelMojo
5 years, 10 months ago (2015-01-27 18:55:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881863002/1
5 years, 10 months ago (2015-01-27 18:55:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 18:57:15 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 18:59:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/599be60af8d7643966e26fe631768e4a5c99e991
Cr-Commit-Position: refs/heads/master@{#313318}

Powered by Google App Engine
This is Rietveld 408576698