Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 881783004: Remove dependency on libc.so.6(GLIBC_2.3.4)(64bit). (Closed)

Created:
5 years, 10 months ago by tommi (sloooow) - chröme
Modified:
5 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency on libc.so.6(GLIBC_2.3.4)(64bit). After the most recent WebRTC roll, removal of dead code reduced the list by one. The dead code referred to sched_getaffinity which pulled this in. R=perkj@chromium.org TBR=mmoss@chromium.org Committed: https://crrev.com/3b7d5ebd4ac6129046e571cb23fda4f0af46d258 Cr-Commit-Position: refs/heads/master@{#313920}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (5 generated)
tommi (sloooow) - chröme
5 years, 10 months ago (2015-01-30 15:24:04 UTC) #1
perkj_chrome
On 2015/01/30 15:24:04, tommi wrote: lgtm
5 years, 10 months ago (2015-01-30 15:28:06 UTC) #2
tommi (sloooow) - chröme
5 years, 10 months ago (2015-01-30 15:44:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881783004/1
5 years, 10 months ago (2015-01-30 15:46:32 UTC) #5
tommi (sloooow) - chröme
+grt for owner stamp (now that I'm no longer there! :D)
5 years, 10 months ago (2015-01-30 15:50:29 UTC) #7
tommi (sloooow) - chröme
+mmoss -grt (due to 'set noparent' in linux)
5 years, 10 months ago (2015-01-30 15:52:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39447)
5 years, 10 months ago (2015-01-30 15:52:36 UTC) #11
tommi (sloooow) - chröme
TBR-ing mmoss to get the official bots green.
5 years, 10 months ago (2015-01-30 15:53:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881783004/1
5 years, 10 months ago (2015-01-30 15:54:29 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 16:02:59 UTC) #15
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b7d5ebd4ac6129046e571cb23fda4f0af46d258 Cr-Commit-Position: refs/heads/master@{#313920}
5 years, 10 months ago (2015-01-30 16:04:01 UTC) #16
Michael Moss
5 years, 10 months ago (2015-01-30 17:29:04 UTC) #17
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698