Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: src/ic/x87/handler-compiler-x87.cc

Issue 881783003: Do not embedd store callback in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: x Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 673 matching lines...) Expand 10 before | Expand all | Expand 10 after
684 __ push(scratch2()); // restore old return address 684 __ push(scratch2()); // restore old return address
685 685
686 ExternalReference ref = ExternalReference( 686 ExternalReference ref = ExternalReference(
687 IC_Utility(IC::kLoadPropertyWithInterceptor), isolate()); 687 IC_Utility(IC::kLoadPropertyWithInterceptor), isolate());
688 __ TailCallExternalReference( 688 __ TailCallExternalReference(
689 ref, NamedLoadHandlerCompiler::kInterceptorArgsLength, 1); 689 ref, NamedLoadHandlerCompiler::kInterceptorArgsLength, 1);
690 } 690 }
691 691
692 692
693 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 693 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
694 Handle<JSObject> object, Handle<Name> name, 694 Handle<JSObject> object, Handle<Name> name, int accessor_index) {
695 Handle<ExecutableAccessorInfo> callback) {
696 Register holder_reg = Frontend(name); 695 Register holder_reg = Frontend(name);
697 696
698 __ pop(scratch1()); // remove the return address 697 __ pop(scratch1()); // remove the return address
699 __ push(receiver()); 698 __ push(receiver());
700 __ push(holder_reg); 699 __ push(holder_reg);
701 __ Push(callback); 700 __ Push(Smi::FromInt(accessor_index));
702 __ Push(name); 701 __ Push(name);
703 __ push(value()); 702 __ push(value());
704 __ push(scratch1()); // restore return address 703 __ push(scratch1()); // restore return address
705 704
706 // Do tail-call to the runtime system. 705 // Do tail-call to the runtime system.
707 ExternalReference store_callback_property = 706 ExternalReference store_callback_property =
708 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 707 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
709 __ TailCallExternalReference(store_callback_property, 5, 1); 708 __ TailCallExternalReference(store_callback_property, 5, 1);
710 709
711 // Return the generated code. 710 // Return the generated code.
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
771 // Return the generated code. 770 // Return the generated code.
772 return GetCode(kind(), Code::NORMAL, name); 771 return GetCode(kind(), Code::NORMAL, name);
773 } 772 }
774 773
775 774
776 #undef __ 775 #undef __
777 } 776 }
778 } // namespace v8::internal 777 } // namespace v8::internal
779 778
780 #endif // V8_TARGET_ARCH_X87 779 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/ic/x64/handler-compiler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698