Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: src/ic/mips/handler-compiler-mips.cc

Issue 881783003: Do not embedd store callback in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: x Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS 7 #if V8_TARGET_ARCH_MIPS
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 648 matching lines...) Expand 10 before | Expand all | Expand 10 after
659 holder()); 659 holder());
660 660
661 ExternalReference ref = ExternalReference( 661 ExternalReference ref = ExternalReference(
662 IC_Utility(IC::kLoadPropertyWithInterceptor), isolate()); 662 IC_Utility(IC::kLoadPropertyWithInterceptor), isolate());
663 __ TailCallExternalReference( 663 __ TailCallExternalReference(
664 ref, NamedLoadHandlerCompiler::kInterceptorArgsLength, 1); 664 ref, NamedLoadHandlerCompiler::kInterceptorArgsLength, 1);
665 } 665 }
666 666
667 667
668 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 668 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
669 Handle<JSObject> object, Handle<Name> name, 669 Handle<JSObject> object, Handle<Name> name, int accessor_index) {
670 Handle<ExecutableAccessorInfo> callback) {
671 Register holder_reg = Frontend(name); 670 Register holder_reg = Frontend(name);
672 671
673 __ Push(receiver(), holder_reg); // Receiver. 672 __ Push(receiver(), holder_reg); // Receiver.
674 __ li(at, Operand(callback)); // Callback info. 673 __ li(at, Operand(Smi::FromInt(accessor_index)));
675 __ push(at); 674 __ push(at);
676 __ li(at, Operand(name)); 675 __ li(at, Operand(name));
677 __ Push(at, value()); 676 __ Push(at, value());
678 677
679 // Do tail-call to the runtime system. 678 // Do tail-call to the runtime system.
680 ExternalReference store_callback_property = 679 ExternalReference store_callback_property =
681 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 680 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
682 __ TailCallExternalReference(store_callback_property, 5, 1); 681 __ TailCallExternalReference(store_callback_property, 5, 1);
683 682
684 // Return the generated code. 683 // Return the generated code.
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
739 // Return the generated code. 738 // Return the generated code.
740 return GetCode(kind(), Code::NORMAL, name); 739 return GetCode(kind(), Code::NORMAL, name);
741 } 740 }
742 741
743 742
744 #undef __ 743 #undef __
745 } 744 }
746 } // namespace v8::internal 745 } // namespace v8::internal
747 746
748 #endif // V8_TARGET_ARCH_MIPS 747 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ic/ic.cc ('k') | src/ic/mips64/handler-compiler-mips64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698