Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 881783003: Do not embedd store callback in handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: x Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 656 matching lines...) Expand 10 before | Expand all | Expand 10 after
667 holder()); 667 holder());
668 668
669 ExternalReference ref = ExternalReference( 669 ExternalReference ref = ExternalReference(
670 IC_Utility(IC::kLoadPropertyWithInterceptor), isolate()); 670 IC_Utility(IC::kLoadPropertyWithInterceptor), isolate());
671 __ TailCallExternalReference( 671 __ TailCallExternalReference(
672 ref, NamedLoadHandlerCompiler::kInterceptorArgsLength, 1); 672 ref, NamedLoadHandlerCompiler::kInterceptorArgsLength, 1);
673 } 673 }
674 674
675 675
676 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback( 676 Handle<Code> NamedStoreHandlerCompiler::CompileStoreCallback(
677 Handle<JSObject> object, Handle<Name> name, 677 Handle<JSObject> object, Handle<Name> name, int accessor_index) {
678 Handle<ExecutableAccessorInfo> callback) {
679 Register holder_reg = Frontend(name); 678 Register holder_reg = Frontend(name);
680 679
681 __ push(receiver()); // receiver 680 __ push(receiver()); // receiver
682 __ push(holder_reg); 681 __ push(holder_reg);
683 __ mov(ip, Operand(callback)); // callback info 682 __ mov(ip, Operand(Smi::FromInt(accessor_index)));
684 __ push(ip); 683 __ push(ip);
685 __ mov(ip, Operand(name)); 684 __ mov(ip, Operand(name));
686 __ Push(ip, value()); 685 __ Push(ip, value());
687 686
688 // Do tail-call to the runtime system. 687 // Do tail-call to the runtime system.
689 ExternalReference store_callback_property = 688 ExternalReference store_callback_property =
690 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate()); 689 ExternalReference(IC_Utility(IC::kStoreCallbackProperty), isolate());
691 __ TailCallExternalReference(store_callback_property, 5, 1); 690 __ TailCallExternalReference(store_callback_property, 5, 1);
692 691
693 // Return the generated code. 692 // Return the generated code.
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 // Return the generated code. 746 // Return the generated code.
748 return GetCode(kind(), Code::NORMAL, name); 747 return GetCode(kind(), Code::NORMAL, name);
749 } 748 }
750 749
751 750
752 #undef __ 751 #undef __
753 } 752 }
754 } // namespace v8::internal 753 } // namespace v8::internal
755 754
756 #endif // V8_TARGET_ARCH_ARM 755 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698