Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 881783003: Do not embedd store callback in handler. (Closed)

Created:
5 years, 10 months ago by ulan
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Do not embedd store callback in handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/a113ce28bf9e9091054425797fe098cd314cc7f5 Cr-Commit-Position: refs/heads/master@{#26360}

Patch Set 1 #

Patch Set 2 : x #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -24 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
ulan
PTAL. Instead of embedding the callback and calling runtime, we embed the accessor index and ...
5 years, 10 months ago (2015-01-30 13:51:45 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-01-30 14:02:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881783003/1
5 years, 10 months ago (2015-01-30 14:11:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/984)
5 years, 10 months ago (2015-01-30 14:16:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881783003/20001
5 years, 10 months ago (2015-01-30 14:20:06 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 14:54:48 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 14:55:04 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a113ce28bf9e9091054425797fe098cd314cc7f5
Cr-Commit-Position: refs/heads/master@{#26360}

Powered by Google App Engine
This is Rietveld 408576698