Issue 881763005: Just visit young array buffers during scavenge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 881763005: Just visit young array buffers during scavenge. (Closed)

Created:
5 years, 10 months ago by Hannes Payer (out of office)

Modified:
5 years, 10 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@split-up-native-context

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

Just visit young array buffers during scavenge. BUG=

Patch Set 11 : #

Total comments: 1

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -30 lines)			Patch
M	src/heap/heap.h	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+7 lines, -2 lines	0 comments	Download
M	src/heap/heap.cc	View	1 2 3 4 5 6 7 8 9	3 chunks	+22 lines, -11 lines	1 comment	Download
M	src/heap/objects-visiting.h	View	1 2 3 4 5 6	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/heap/objects-visiting.cc	View	1 2 3 4 5 6 7 8 9	6 chunks	+34 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ulan

https://codereview.chromium.org/881763005/diff/200001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/881763005/diff/200001/src/heap/heap.cc#newcode1712 src/heap/heap.cc:1712: &last_young_object_recorded); It just occurred to me that this won't ...

5 years, 10 months ago (2015-02-03 11:15:21 UTC) #3

Hannes Payer (out of office)

5 years, 10 months ago (2015-02-03 15:54:19 UTC) #4

As discussed offline, we have to handle that case on a different level. I will
close this cl.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 881763005: Just visit young array buffers during scavenge. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : #

Messages