tools/clang/blink_gc_plugin/RecordInfo.h - Issue 881763003: Roll Clang 223108:228742

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/RecordInfo.h

Issue 881763003: Roll Clang 223108:228742 (Closed) Base URL: precise:/work/chromium/src@clang_roll_226907

Patch Set: Don't run SandboxBPF.SigBus under ASan; SIGBUS is treated as a fatal signal after r225630 Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/clang/blink_gc_plugin/RecordInfo.h

diff --git a/tools/clang/blink_gc_plugin/RecordInfo.h b/tools/clang/blink_gc_plugin/RecordInfo.h

index 82fb604137dfedd0a0cb3361506600e1c9a2de08..da2f41551cf6a961bc25543d2c4f5f3a12d1c456 100644

--- a/tools/clang/blink_gc_plugin/RecordInfo.h

+++ b/tools/clang/blink_gc_plugin/RecordInfo.h

@@ -23,6 +23,7 @@ class RecordCache;

class GraphPoint {

public:

GraphPoint() : traced_(false) {}

+ virtual ~GraphPoint() {}

void MarkTraced() { traced_ = true; }

bool IsProperlyTraced() { return traced_ || !NeedsTracing().IsNeeded(); }

virtual const TracingStatus NeedsTracing() = 0;