Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 881753003: Revert of Create a Android Sync integration test for typed URLs (Closed)

Created:
5 years, 10 months ago by Miguel Garcia
Modified:
5 years, 10 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create a Android Sync integration test for typed URLs (patchset #4 id:140001 of https://codereview.chromium.org/862113005/) Reason for revert: This is breaking building chrome/android:chrome_sync_shell_test_apk with gn due to a dependency to the autogenerated enum org.chromium.ui.base.PageTransition; I am not sure why no bots failed when landing it (we don't seem to have gn builder upstream for android?) but reverting it locally makes it build again. To repro: Reapply the patch and run gn gen out/Release --args='is_debug=false os="android" cpu_arch="arm" use_goma=true goma_dir="/usr/local/google/clank/goma/goma"' ninja -C out/Release -j 200 chrome/android:chrome_sync_shell_test_apk Original issue's description: > Create a Android Sync integration test for typed URLs > > This CL introduces JNI plumbing for one method of the FakeServer's > verification API. One test (testUploadTypedUrl) has been added to use > the API; it types a URL on the client and verifies that the URL was > sent to the server. > > BUG=NONE > > Committed: https://crrev.com/cba424b9309c8c75d0a3797b9b228f7ef11425e4 > Cr-Commit-Position: refs/heads/master@{#313824} TBR=nyquist@chromium.org,maxbogue@chromium.org,zea@chromium.org,pvalenzuela@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://crrev.com/e636eab5a532be27a3953409f3a3534bd976a4da Cr-Commit-Position: refs/heads/master@{#313898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -104 lines) Patch
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java View 3 chunks +1 line, -23 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java View 4 chunks +0 lines, -38 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sync/sync_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.h View 1 chunk +0 lines, -9 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.cc View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Miguel Garcia
Created Revert of Create a Android Sync integration test for typed URLs
5 years, 10 months ago (2015-01-30 11:19:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881753003/1
5 years, 10 months ago (2015-01-30 11:20:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 11:20:58 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e636eab5a532be27a3953409f3a3534bd976a4da Cr-Commit-Position: refs/heads/master@{#313898}
5 years, 10 months ago (2015-01-30 11:21:51 UTC) #4
Miguel Garcia
5 years, 10 months ago (2015-01-30 11:27:52 UTC) #5
Message was sent while issue was closed.
On 2015/01/30 11:21:51, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e636eab5a532be27a3953409f3a3534bd976a4da
> Cr-Commit-Position: refs/heads/master@{#313898}

I filed crbug.com/453771 so that we get a trybot upstream for GN builds

Powered by Google App Engine
This is Rietveld 408576698