Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 881753002: Run App tests on Android. (Closed)

Created:
5 years, 11 months ago by qsr
Modified:
5 years, 10 months ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Run App tests on Android. Also refactor os selector in mojo/tools/data/apptests and mojo/tools/data/unittests R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b96671e5ba978bfd00782de28832025ead0be842

Patch Set 1 #

Patch Set 2 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -24 lines) Patch
M mojo/tools/apptest_runner.py View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/tools/data/apptests View 3 chunks +4 lines, -0 lines 0 comments Download
M mojo/tools/data/unittests View 2 chunks +4 lines, -12 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 chunk +1 line, -4 lines 0 comments Download
M mojo/tools/mopy/config.py View 1 chunk +22 lines, -0 lines 0 comments Download
M mojo/tools/test_runner.py View 1 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
qsr
5 years, 11 months ago (2015-01-27 09:57:15 UTC) #1
qsr
Trung, gentle ping?
5 years, 10 months ago (2015-01-28 11:37:46 UTC) #2
viettrungluu
Hmmm, I like making test_runner.py also get the Config from GN args. I don't think ...
5 years, 10 months ago (2015-01-28 18:32:44 UTC) #3
qsr
On 2015/01/28 18:32:44, viettrungluu wrote: > Hmmm, I like making test_runner.py also get the Config ...
5 years, 10 months ago (2015-01-28 18:33:50 UTC) #4
viettrungluu
On 2015/01/28 18:33:50, qsr wrote: > On 2015/01/28 18:32:44, viettrungluu wrote: > > Hmmm, I ...
5 years, 10 months ago (2015-01-28 22:01:16 UTC) #5
qsr
5 years, 10 months ago (2015-01-29 10:05:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b96671e5ba978bfd00782de28832025ead0be842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698