Issue 88173002: Flatten cons string for single character substrings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 88173002: Flatten cons string for single character substrings. (Closed)

Created:
7 years ago by Yang

Modified:
7 years ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Flatten cons string for single character substrings. For substrings of non-flat cons strings, we bail out to runtime. For single character substrings, we forget to flatten it. This causes successive bailouts. R=bmeurer@chromium.org BUG=323041 LOG=Y Committed: https://code.google.com/p/v8/source/detail?r=18081

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	src/heap.cc	View		3 chunks	+7 lines, -5 lines	0 comments	Download
	M	src/runtime.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r18081 (presubmit successful).

Expand Messages | Collapse Messages