Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 881723002: Remove google_apis::ResourceEntry and related code (Closed)

Created:
5 years, 11 months ago by satorux1
Modified:
5 years, 10 months ago
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove google_apis::ResourceEntry and related code The class derives from WAPI, which is no longer used. BUG=357038 TEST=syncfs unit tests pass TBR=rogerta@chromium.org # for google_apis/{BUILD.gn,google_apis.gyp) Committed: https://crrev.com/d11f81682b5fb8dfe9bb237d5db0024fceea3e6f Cr-Commit-Position: refs/heads/master@{#313430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -201 lines) Patch
M chrome/browser/drive/drive_api_util.h View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/drive/drive_api_util.cc View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc View 7 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.h View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_test_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_service_helper.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer_unittest.cc View 11 chunks +50 lines, -40 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D google_apis/drive/gdata_wapi_parser.h View 1 chunk +0 lines, -65 lines 0 comments Download
D google_apis/drive/gdata_wapi_parser.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M google_apis/google_apis.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
satorux1
tzik: syncfs kinaba: google_apis and drive fukino: FYI
5 years, 11 months ago (2015-01-27 06:35:44 UTC) #2
kinaba
On 2015/01/27 06:35:44, satorux1 wrote: > tzik: syncfs > kinaba: google_apis and drive > fukino: ...
5 years, 11 months ago (2015-01-27 06:39:58 UTC) #3
tzik
lgtm
5 years, 11 months ago (2015-01-27 12:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881723002/1
5 years, 11 months ago (2015-01-28 01:44:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/38785)
5 years, 11 months ago (2015-01-28 01:50:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/881723002/1
5 years, 11 months ago (2015-01-28 01:56:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 04:11:37 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 04:12:49 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d11f81682b5fb8dfe9bb237d5db0024fceea3e6f
Cr-Commit-Position: refs/heads/master@{#313430}

Powered by Google App Engine
This is Rietveld 408576698