Add new script to create release branches.

Add new script to create release branches.

BUG=chromium:451975
TBR=tandrii@chromium.org
NOTRY=true
LOG=n

TEST=./script_test.py
TEST=tools/release/create_release.py -r machenbach@chromium.org -a machenbach@chromium.org --dry-run

Committed: https://crrev.com/1bd398ab16a2cfbff6e116bcf21c8efd2a0b6f04
Cr-Commit-Position: refs/heads/master@{#26364}

[Michael Achenbach, 2015-01-30 14:59:31]

machenbach@chromium.org changed reviewers:
+ tandrii@chromium.org

[Michael Achenbach, 2015-01-30 15:04:19]

PTAL. Big parts of the new script are copied from the old push_to_candidates. I
won't invest into code sharing as the old script is going to be deleted. I
marked the step classes that were copied to ease review.

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
File tools/release/create_release.py (right):

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:50: class IncrementVersion(Step):
Copied.

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:77: # The new version is not a candidate.
Small change to the original to make sure that this is not a candidate, but a
real release.

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:94: class PrepareChangeLog(Step):
Copied

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:147: class EditChangeLog(Step):
Copied

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:181: MESSAGE = "Add ChangeLog changes to release
branch."
Copied

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:197: class CommitBranch(Step):
Partially copied (changed commit message and commit to branch in the end)

[tandrii(chromium), 2015-01-30 15:46:40]

lgtm

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
File tools/release/create_release.py (right):

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:38: print "Release revision %s" %
self["push_hash"]
How about swapping lines assert with print? If assert fails, having the value
printed would be nice.

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:212: text = SplitMapJoin("\n\n",
SplitMapJoin("\n", strip, " "), "\n\n")(text)
nit: I really liked your recent "str.strip" intead of "lambda line:
line.strip()" .
of course, it's not Py3 compatible, but who cares?!

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:262: self.DeleteBranch("work-branch")
I wonder, is it useful to run git.gc here?

[Michael Achenbach, 2015-01-30 16:46:07]

Done

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
File tools/release/create_release.py (right):

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:38: print "Release revision %s" %
self["push_hash"]
On 2015/01/30 15:46:39, tandrii(chromium) wrote:
> How about swapping lines assert with print? If assert fails, having the value
> printed would be nice.

Done.

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:212: text = SplitMapJoin("\n\n",
SplitMapJoin("\n", strip, " "), "\n\n")(text)
Done. This was some older code. Who knows where I copied that from...

https://codereview.chromium.org/881683004/diff/20001/tools/release/create_rel...
tools/release/create_release.py:262: self.DeleteBranch("work-branch")
On 2015/01/30 15:46:39, tandrii(chromium) wrote:
> I wonder, is it useful to run git.gc here?

Done.

[Michael Achenbach, 2015-01-30 16:46:18]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2015-01-30 16:46:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/881683004/50001

[commit-bot: I haz the power, 2015-01-30 16:46:50]

Committed patchset #4 (id:50001)

[commit-bot: I haz the power, 2015-01-30 16:46:56]

Patchset 4 (id:??) landed as
https://crrev.com/1bd398ab16a2cfbff6e116bcf21c8efd2a0b6f04
Cr-Commit-Position: refs/heads/master@{#26364}