Source/core/frame/FrameDestructionObserver.cpp - Issue 881683003: Issue FrameDestructionObserver::frameDestroyed() notification on detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameDestructionObserver.cpp

Issue 881683003: Issue FrameDestructionObserver::frameDestroyed() notification on detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: weak references no longer needed Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameDestructionObserver.cpp

diff --git a/Source/core/frame/FrameDestructionObserver.cpp b/Source/core/frame/FrameDestructionObserver.cpp

index 4d755f15a14294705633eb6f63f6e2134030e3c3..8c1d4fc2d64f5c995e85eea65f3a046750fca2c0 100644

--- a/Source/core/frame/FrameDestructionObserver.cpp

+++ b/Source/core/frame/FrameDestructionObserver.cpp

@@ -54,12 +54,10 @@ void FrameDestructionObserver::observeFrame(LocalFrame* frame)

m_frame->addDestructionObserver(this);

}

-#if !ENABLE(OILPAN)

void FrameDestructionObserver::frameDestroyed()

{

m_frame = nullptr;

}

-#endif

void FrameDestructionObserver::willDetachFrameHost()

{

« no previous file with comments | « Source/core/frame/FrameDestructionObserver.h ('k') | Source/core/frame/LocalDOMWindow.h » ('j') | no next file with comments »