Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: Source/core/frame/FrameDestructionObserver.h

Issue 881683003: Issue FrameDestructionObserver::frameDestroyed() notification on detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: weak references no longer needed Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/frame/DOMWindowProperty.h ('k') | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2011 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 18 matching lines...) Expand all
29 #include "platform/heap/Handle.h" 29 #include "platform/heap/Handle.h"
30 30
31 namespace blink { 31 namespace blink {
32 32
33 class LocalFrame; 33 class LocalFrame;
34 34
35 class FrameDestructionObserver : public WillBeGarbageCollectedMixin { 35 class FrameDestructionObserver : public WillBeGarbageCollectedMixin {
36 public: 36 public:
37 explicit FrameDestructionObserver(LocalFrame*); 37 explicit FrameDestructionObserver(LocalFrame*);
38 38
39 #if !ENABLE(OILPAN)
40 // Oilpan: there is no known need for directly observing
41 // frameDestroyed() with Oilpan enabled, as its clearing is
42 // handled by keeping a weak reference.
43 //
44 // A weak callback version of frameDestroyed() can be reintroduced
45 // later, should the need arise.
46 virtual void frameDestroyed(); 39 virtual void frameDestroyed();
47 #endif
48 virtual void willDetachFrameHost(); 40 virtual void willDetachFrameHost();
49 41
50 LocalFrame* frame() const { return m_frame; } 42 LocalFrame* frame() const { return m_frame; }
51 43
52 virtual void trace(Visitor*); 44 virtual void trace(Visitor*);
53 45
54 protected: 46 protected:
55 #if !ENABLE(OILPAN) 47 #if !ENABLE(OILPAN)
56 virtual ~FrameDestructionObserver(); 48 virtual ~FrameDestructionObserver();
57 #endif 49 #endif
58 50
59 void observeFrame(LocalFrame*); 51 void observeFrame(LocalFrame*);
60 52
61 RawPtrWillBeWeakMember<LocalFrame> m_frame; 53 RawPtrWillBeMember<LocalFrame> m_frame;
62 }; 54 };
63 55
64 } 56 }
65 57
66 #endif 58 #endif
OLDNEW
« no previous file with comments | « Source/core/frame/DOMWindowProperty.h ('k') | Source/core/frame/FrameDestructionObserver.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698